Rework OnboardApp to adjust to new architecture #6115
+119
−250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2025
jpelgrom
reviewed
Dec 2, 2025
...tlin/io/homeassistant/companion/android/onboarding/nameyourdevice/NameYourDeviceViewModel.kt
Show resolved
Hide resolved
jpelgrom
approved these changes
Dec 3, 2025
Member
jpelgrom
left a comment
jpelgrom
left a comment
There was a problem hiding this comment.
Tested and change looks good
...t/companion/android/onboarding/nameyourweardevice/navigation/NameYourWearDeviceNavigation.kt
Outdated
Show resolved
Hide resolved
…ing/nameyourweardevice/navigation/NameYourWearDeviceNavigation.kt Co-authored-by: Joris Pelgröm <jpelgrom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up the
OnboardAppclass and keep it only for the wear onboarding since it is not needed for the rest while removing all the useless parameters.Checklist
Any other notes
I tested the onboarding on TV, mobile and wear.