WIP move Ruby and Bundler install logic #1676
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
changed the title
The goal is to install Ruby and Bundler versions before instantiating any "language pack" because the `detect` logic checks if specific gems are installed. By moving moving this logic to a class method, we can decouple it from the detection lifecycle.
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
80c8dd4 to
f158ffc
Compare
The goal is to install Ruby and Bundler versions before instantiating any "language pack" because the `detect` logic checks if specific gems are installed. By moving moving this logic to a class method, we can decouple it from the detection lifecycle.
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
e3785ac to
6b5e358
Compare
The goal is to install Ruby and Bundler versions before instantiating any "language pack" because the `detect` logic checks if specific gems are installed. By moving moving this logic to a class method, we can decouple it from the detection lifecycle.
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
2 times, most recently
from
272aa1f to
c4b0f53
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
c4b0f53 to
f9303df
Compare
Both `ruby_layer_path` and `gem_layer_path` point at the same value which is better defined as "app_path".
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
2 times, most recently
from
d7f1af8 to
9156318
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
9156318 to
98ab5e1
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
3ce0c35 to
1a67f36
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
c2e8106 to
3853863
Compare
The syntax highlighting doesn't like there combination of heredoc and ERB, moving it is an ergonomic QOL improvement for developers using an IDE with syntax highlighting.
Added in 74b4284 this was when the stack image included a copy of java, which it no longer does. The local `bin` dir is put on the path in the general case but this was never refactored away.
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
7a0a03e to
aaa2c74
Compare
This is no longer needed
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
9b20e5f to
b10c4da
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
3eed7ce to
abeecc4
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
6446332 to
9bd851a
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
9eb2e01 to
45e20d4
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
2 times, most recently
from
c6eade5 to
9898084
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
9898084 to
b08b8d0
Compare
schneems
force-pushed
the
schneems/explicit-bundler-version-2025-12
branch
from
bd80e90 to
44c9ab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to install Ruby and Bundler versions before instantiating any "language pack" because the
detectlogic checks if specific gems are installed. By moving moving this logic to a class method, we can decouple it from the detection lifecycle.