-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(contrib/drivers/pgsql&mssql&oracle): add Replace support for pgsql/mssql/oracle #4547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gqcn
wants to merge
27
commits into
master
Choose a base branch
from
feat/gdb-mssql-replace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+714
−215
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
63c2bb7
feat(contrib/drivers/dm): add Replace/InsertIgnore support for dm
gqcn 0d122d6
up
gqcn 8723999
up
gqcn ffe65d9
merge master
gqcn 91e3f1e
Merge branch 'master' of github.com:gogf/gf into feat/gdb-pgsql-replace
gqcn 99536c8
up
gqcn ba44475
Update contrib/drivers/pgsql/pgsql_do_insert.go
gqcn 111f8b3
Update contrib/drivers/pgsql/pgsql_z_unit_upsert_test.go
gqcn 01cd4a3
up
gqcn b7cd39a
up
gqcn d8fa0a7
Update contrib/drivers/pgsql/pgsql_do_insert.go
gqcn 67a8a28
Update contrib/drivers/pgsql/pgsql_do_insert.go
gqcn 4080452
fix(contrib/drivers/pgsql): Fixed table field call issue in primary k…
LanceAdd 5f664f3
up
gqcn bfe31a4
merge
gqcn 17906e3
up
gqcn f6a7fd2
fix(gendao): Added support for UUID types (#4548)
LanceAdd 8b48a60
up
gqcn 36d6335
Update contrib/drivers/dm/dm_do_insert.go
gqcn 73b91ed
Update contrib/drivers/mssql/mssql_do_insert.go
gqcn 141b5c1
Update contrib/drivers/mssql/mssql_z_unit_basic_test.go
gqcn ffb3aac
Update contrib/drivers/mssql/mssql_do_insert.go
gqcn 57e5126
merge
gqcn 3658a09
up
gqcn ce76575
up
gqcn dddfe46
up
gqcn bc3b20e
up
gqcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current logic only checks if at least ONE primary key exists in the data, then uses ALL primary keys for conflict detection. For tables with composite primary keys, this could cause issues if only some parts of the composite key are present in the data. Consider checking that ALL primary keys are present in the data before setting
conflictKeys = primaryKeys, or only include the primary keys that are actually present in the data.