Skip to content

Conversation

@wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Dec 8, 2025

Why are the changes needed?

Tweaking rs code gen. Removing the extension-module feature from pyo3.

What changes were proposed in this pull request?

Update cargo.

How was this patch tested?

Tested by running maturin from separate project locally.

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor changed the base branch from master to v2 December 8, 2025 03:47
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at eduardo@union.ai.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at eduardo@union.ai.

@wild-endeavor wild-endeavor changed the title Rs remove extension module flyteidl rust gen remove extension module Dec 8, 2025
@wild-endeavor wild-endeavor changed the title flyteidl rust gen remove extension module flyteidl crate remove extension module Dec 8, 2025
@wild-endeavor wild-endeavor merged commit a1551a4 into v2 Dec 8, 2025
4 checks passed
@wild-endeavor wild-endeavor deleted the rs-remove-extension-module branch December 8, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants