fix: ensure modal={false} applies when using controlled open state #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue where
modal={false}had no effect when using a controlledopenprop.Why
Internally, the
modalcheck only applied on initial mount. When controlling the drawer state using theopenprop, pointer events were not correctly restored on open.How
Added
isOpenas a dependency to theuseEffectthat appliespointer-events: autowhenmodalis false.Related
No open issue yet, but related to modal mode accessibility and pointer control.
Thanks for this great library! 😊