Fix out-of-bounds access in XWindowsScreen::updateButtons #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT. I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway.
shymega
pushed a commit
to input-leap/input-leap
that referenced
this pull request
Dec 18, 2022
This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT. I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway. (Note from Input Leap maintainer @shymega: PR imported from debauchee/barrier#1827) Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to input-leap/input-leap
that referenced
this pull request
Dec 18, 2022
This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT. I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk> (Maintainer's note (@shymega): PR from debauchee/barrier#1827) (cherry picked from commit 4cc700c)
1 task
shymega
added a commit
to input-leap/input-leap
that referenced
this pull request
Dec 18, 2022
This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT. I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk> (Maintainer's note (@shymega): PR from debauchee/barrier#1827) (cherry picked from commit 4cc700c) Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code triggers an assertion in gcc's std_vector.h on my system due to a logical button 0 causing a write to m_buttons[-1], and a SIGABRT.
I've tried to make this code do what it seems to be intended to do, but m_buttons isn't actually read from anywhere anyway.
Contributor Checklist:
doc/newsfragmentsdirectory IF it is auser-visible change (and make sure to read the
README.mdin that directory)