`frr` builds `libyang3` but requires `libyang2`

[signed-log]

Another weird issue with the image builder (We are running a fully stock vyos/vyos-build image with no proxying/caching or anything (the image in the log is just a mirror of vyos-build branch current), sorry again for that)

./package_builder.py current \
        --vyos-build-docker ${VYBUILD_IMAGE} \
        --clone-org vyos \
        --analyze-org vyos \
        --debranding-name ${DEBRANDING_NAME} \
        --debug
# succeeds
./image_builder.py current \
        --vyos-build-docker ${VYBUILD_IMAGE} \
        --build-by "CI ${CI_PIPELINE_ID} on ${CI_SERVER_FQDN}, commit ${VYBUILD_COMMIT_SHORT_SHA}" \
        --clone-org vyos \
        --debug
# fails

# Also tried the above after 
./package_builder.py current --vyos-build-docker ${VYBUILD_IMAGE} --clone-org vyos --analyze-org vyos --single-package frr --debug --force-build

Package builder log : https://paste.opensuse.org/pastes/d5a8960ca69b
Image log : https://paste.opensuse.org/pastes/b1e51334a883

[dd010101]

Good catch. That's puzzling, the official build script produces this and it was changed intentionally with upgrade to frr 10.2 here to replace libyang2 with libyang3 long time ago.

But... The frr 10.2 resulting package says says:

Package: frr
Version: 10.2.4-0
Architecture: amd64
Maintainer: David Lamparter equinox-debian@diac24.net
Installed-Size: 37723
Pre-Depends: adduser
Depends: iproute2, logrotate (>= 3.2-11), lsof, libc-ares2 (>= 1.7.0), libc6 (>= 2.34), libcap2 (>= 1:2.10), libcrypt1 (>= 1:4.1.0), libjson-c5 (>= 0.15), liblua5.3-0, libpam0g (>= 0.99.7.1), libpcre2-posix3 (>= 10.34), libprotobuf-c1 (>= 1.0.1), libreadline8 (>= 7.0~rc1), libyang2 (>= 2.1.148-1)

It wants libyang2 (>= 2.1.148-1) indeed, so I'm not sure what is going on here...
The frr documentation suggests libyang2 as well. Apparently the frr supports libyang3 somehow but I suppose not with the current setup as is done in the official build script.

If anyone knows how VyOS team managed to build the frr with the current official build script so it will accept libyang3 then please tell, because I have no idea how they manage to do that. My best guess is that the official script is broken and their image build works just because the APT repository has both https://packages.vyos.net/repositories/current/pool/main/liby/, it looks like they did build the libyang2 in past, then replace it with libyang3, but the newly built libyang3 is unused and thus they still used the previously built libyang2 for the image build that was left behind as leftover, this explain why the build script produces incomplete result if we execute it from scratch, meanwhile image build with official repo works fine.

As workaround we can patch the version during build back to v2.1.148 at least for now.

This should make the frr build the libyang2_2.1.148-1_amd64.deb again, please tell me if it does.

[signed-log]

This should make the frr build the libyang2_2.1.148-1_amd64.deb again, please tell me if it does.

It does and the image generates, thank you.

Will run smoketests later today or tomorrow to check everything works