infra(helm): Allow concurrency pool settings via Helm #33007
+147
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31086
What
You can't configure concurrency pools via Helm, meaning it defaults to 1 and needs to be click ops'd, which is not a viable path for a production deployment (ask me how I know).
This allows you to do the following in Helm:
How
Follows the standard pattern
Tests
Template test:
The same test on
master:Local deployment
And we can see

and

Permutations
Also tested
defaultLimit=> 4defaultLimitunsetpoolunsetWhich all worked.
Side Node: Test Setup
Side node, I tried to figure out how one is supposed to test this with local image builds and that's the best I could come up with. This was relevant too: #30427
So I needed
With the following changes:
And for the deployment:
Caveats
dagsterDaemon.runCoordinator.config, since that's wheremaxConcurrentRunssits (rather thanconcurrency.runs.max_concurrent_runsas in thedagster.yaml)config.py. I'd probably use literals, but that doesn't seem to be the pattern here.opGranularityRunBufferfield which doesn't really show up in the docs, but it does show up here:dagster/python_modules/dagster/dagster/_core/instance/config.py
Line 459 in d538aed
Changelog