Bug: Suspicious Page not generating as normal

[samuelask]

The suspicious page is only generating a blank page in the end loottable location.

To Reproduce
Steps to reproduce the behavior:

1. Go to the end and look for end cities
2. Find a end city, open up the loot chest
3. You will see that every Suspicious page is empty, just a blank page. However the Uni dialer is spawning as normal.

Expected behavior
Your supposed to find a suspicious page and it will automatically change its nbt data to display a non generated adress. Making it so you can explore other dimensions.

Screenshots
End city loot

Mod version
JSG 1.12.2
Version 4.11.2.8

Additional context
Im playing with galacticraft + its extended mod. I have 45 different dimensions that all have non generated gates. It should 100% generate a Suspicious page with a non generated adress. (And it does when manually spawning in structures containing Suspicious pages)

My whole JSG config (as .zip)
jsg.zip

[Fredyman95]

I think that suspicious page should generates only in JSG structures + in stronghold (this page generate only END gate address)

but maybe we messed something up...

[samuelask]

I think that suspicious page should generates only in JSG structures + in stronghold (this page generate only END gate address)

but maybe we messed something up...

“end_city_treasure.json” has the “jsg:page_notebook“ in it. So should be intended to spawn a suspicious page?

Maybe “spawnSusPageInChest” isn’t called when dealing with other loottables other than jsg? It’s supposed to replace the “jsg:page_notebook“ in the chest to a Suspicious page

[Fredyman95]

“end_city_treasure.json” has the “jsg:page_notebook“ in it. So should be intended to spawn a suspicious page?

Maybe “ spawnSusPageInChest” isn’t working properly. It’s supposed to replace the “jsg:page_notebook“ in the chest to a Suspicious page

page_notebook have more states [data] - empty, filled, suspicious ...

so there is no give command for suspicious as /give @p suspicious_page 1 0 but if I remember right its /give @p notebook_page 1 2

[samuelask]

“end_city_treasure.json” has the “jsg:page_notebook“ in it. So should be intended to spawn a suspicious page?
Maybe “ spawnSusPageInChest” isn’t working properly. It’s supposed to replace the “jsg:page_notebook“ in the chest to a Suspicious page

page_notebook have more states [data] - empty, filled, suspicious ...

so there is no give command for suspicious as /give @p suspicious_page 1 0 but if I remember right its /give @p notebook_page 1 2

Yeah but what would be the point in spawning in an empty page as end loot? I think it’s supposed to spawn a suspicious one.

[samuelask]

Maybe the loottable is named wrong here?

Mod-JSG-1.12.2/src/main/java/tauri/dev/jsg/worldgen/structures/JSGStructure.java

Line 287 in e37393b

case "loot_end":

case "loot_end": should be “end_city_treasure”

[Fredyman95]

Maybe the loottable is named wrong here?

Mod-JSG-1.12.2/src/main/java/tauri/dev/jsg/worldgen/structures/JSGStructure.java

Line 287 in e37393b

case "loot_end":

case "loot_end": should be “end_city_treasure”

If this will be wrong there will will be no loot at all.

I'm still leaning towards it like this: #353 (comment)

[samuelask]

Loot would still spawn I think, the end_city_treasure.json would make sure of it.

Also there is no reference to a “loot_end“ anywhere. So that case is literally doing nothing anyway.