Skip to content

Conversation

@PWagner1
Copy link
Contributor

@PWagner1 PWagner1 commented Dec 2, 2025

* Implemented #2230
* Rest of filescoped namespaces
@PWagner1 PWagner1 added this to the Version 110 milestone Dec 2, 2025
@PWagner1 PWagner1 requested a review from a team as a code owner December 2, 2025 17:18
@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. area:toolkit All issues related to the toolkit components. version:110 All things to do with V110. labels Dec 2, 2025
@giduac
Copy link
Contributor

giduac commented Dec 3, 2025

@Krypton-Suite/reviewers

  • Mixing all kind of files in one PR has been discussed a time or two... iirc
  • What I've read about the IDE generated files and making those use file scoped namespaces might causes a problem or two. My advice would be to leave formatting of those (system generated files) to the system.

The SearchBox

  • Is not really a control but an implementation.
  • It is not part of Winforms and should not be in here.

I think I mentioned this earlier but these kind of tools or utilities could be hosted in a lib called "Krypton Utilities"
That will keep controls and implementations separated. I would also draw this line for Extended.

@PWagner1
Copy link
Contributor Author

PWagner1 commented Dec 3, 2025

@Krypton-Suite/reviewers

  • Mixing all kind of files in one PR has been discussed a time or two... iirc
  • What I've read about the IDE generated files and making those use file scoped namespaces might causes a problem or two. My advice would be to leave formatting of those (system generated files) to the system.

The SearchBox

  • Is not really a control but an implementation.
  • It is not part of Winforms and should not be in here.

I think I mentioned this earlier but these kind of tools or utilities could be hosted in a lib called "Krypton Utilities" That will keep controls and implementations separated. I would also draw this line for Extended.

@giduac

One of the intended applications for this is the KryptonExceptionDialog I can make a internal version of it that is not visible to the public. I like the idea of a new Krypton.Utilities library, as it can be exclusive to the AIO package and not have to manage another NuGet package, so I'll put the public version in there. Please keep this PR open so I can see what files I need to modify etc.

@PWagner1 PWagner1 marked this pull request as draft December 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested. version:110 All things to do with V110.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants